allow Openbis session in ologin #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@JosePizarro3 I tried to keep the function "as is" for compatibility. There are a few places of lines similar to this class OpenbisEntities:
def __init__(self, url: str = ""):
self.openbis = ologin(url=url)I think to keep compatibility high it would make sense to move away from this pattern into something more general where sessions can be provided, e.g. class OpenbisEntities:
def __init__(self, openbis: Openbis | str = None):
self.openbis = ologin(url=openbis)The default behaviour could replicate the current use of environmental variables. Of course we could stick with the Let me know what you think |
JosePizarro3
approved these changes
Oct 21, 2025
Member
JosePizarro3
left a comment
JosePizarro3
left a comment
There was a problem hiding this comment.
Thanks, looks good to me.
If you want, feel free to change url to whatever other variable name you feel it is more appropiate. You just need to grep all appearances of ologin in bam_masterdata and tests, tho I don't think there are many.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the library uses the
ologinfunction open Openbis sessions in various places.ologinis dependent on a specific environmental variables.To allow more flexible use of the library, this small patch enables the user to pass through existing Openbis sessions that might have been opened in a different context.